Fossil

Check-in [acba194c]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed bug where /doc could only be read if the user had checkout security - drh adds: This is not a bug. Checkout permission prevents /doc from being used to "checkout" any version of any file.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | dead-end
Files: files | file ages | folders
SHA1:acba194c0dfb3e7e5c5b6116ad53b5e4aab99e5f
User & Date: jeremy_c 2010-01-13 10:10:17
Original Comment: Fixed bug where /doc could only be read if the user had checkout security. Users with read wiki security can now also read /doc
Context
2010-01-13
10:10
Fixed bug where /doc could only be read if the user had checkout security - drh adds: This is not a bug. Checkout permission prevents /doc from being used to "checkout" any version of any file. Closed-Leaf check-in: acba194c user: jeremy_c tags: dead-end
09:58
Fixed bug where the ticket report view page was checking the wrong security attribute (too secure) which was causing people who should be able to view ticket reports to not be able to view ticket reports. check-in: 5fc36e2f user: jeremy_c tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/doc.c.

335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
  int vid = 0;                      /* Artifact of baseline */
  int rid = 0;                      /* Artifact of file */
  int i;                            /* Loop counter */
  Blob filebody;                    /* Content of the documentation file */
  char zBaseline[UUID_SIZE+1];      /* Baseline UUID */

  login_check_credentials();
  if( !g.okRead ){ login_needed(); return; }
  zName = PD("name", "tip/index.wiki");
  for(i=0; zName[i] && zName[i]!='/'; i++){}
  if( zName[i]==0 || i>UUID_SIZE ){
    goto doc_not_found;
  }
  memcpy(zBaseline, zName, i);
  zBaseline[i] = 0;







|







335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
  int vid = 0;                      /* Artifact of baseline */
  int rid = 0;                      /* Artifact of file */
  int i;                            /* Loop counter */
  Blob filebody;                    /* Content of the documentation file */
  char zBaseline[UUID_SIZE+1];      /* Baseline UUID */

  login_check_credentials();
  if( !g.okRdWiki ){ login_needed(); return; }
  zName = PD("name", "tip/index.wiki");
  for(i=0; zName[i] && zName[i]!='/'; i++){}
  if( zName[i]==0 || i>UUID_SIZE ){
    goto doc_not_found;
  }
  memcpy(zBaseline, zName, i);
  zBaseline[i] = 0;