Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
| Comment: | Added a parameter to style_footer() and renamed it to match its actual function (style_body_and_footer()) so we can add a CSS class to each page that indicates which major Fossil feature served the page, so we can have module-specific CSS. |
|---|---|
| Downloads: | Tarball | ZIP archive |
| Timelines: | family | ancestors | descendants | both | default-css-cleanups |
| Files: | files | file ages | folders |
| SHA3-256: |
ef5424b683ad2830bfb111ea5756e00e |
| User & Date: | wyoung 2020-11-05 23:15:41.862 |
There are several non-obvious things about this commit.
The rules I used for picking the "page type" for each call to style_body_and_footer() are:
Collect multi-page features under a single page type: e.g. all "forum" pages use the same type.
All "test" type pages are type "test", no matter where they're served from, so you can do something type-specific with them, like give the page title a different color. If this is later considered a design error, one could change these instances to, e.g. "backlink test" for the case in
backlink.c.Where there are multiple pages that don't compose a major user-facing feature, I sometimes used the name of the file where those pages are collected as the common type for pages served from that file. e.g. "cache"
Other points of interest:
The implementation of
proc styleFooterin TH1 should probably have an optional parameter added to pass along tostyle_body_and_footer()rather than hard-code "th1".Since none of these names are currently used for anything, they can all change until someone locks them down by making use of them. I plan only to use "forum" in a subsequent commit. Everything else is up in the air.
|
2020-11-05
| ||
| 23:41 | Using the new "forum" page type to simplify repetitive CSS rules. ... (check-in: 064c677a user: wyoung tags: default-css-cleanups) | |
| 23:15 | Added a parameter to style_footer() and renamed it to match its actual function (style_body_and_footer()) so we can add a CSS class to each page that indicates which major Fossil feature served the page, so we can have module-specific CSS. ... (check-in: ef5424b6 user: wyoung tags: default-css-cleanups) | |
| 22:34 | Moved a comment down in src/style.c and removed a part of it that seems to refer to inline CSS that's since moved to style.css. ... (check-in: a040a5d2 user: wyoung tags: default-css-cleanups) | |